Add Debian 12 (bookworm) images #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base/base.bzl
Outdated
| @@ -119,7 +119,7 @@ def distro_components(distro): | |||
| base = ":static_" + user + "_" + arch + "_" + distro, | |||
| tars = [ | |||
| deb_pkg(arch, distro, "libc6"), | |||
| deb_pkg(arch, distro, "libssl1.1"), | |||
| deb_pkg(arch, distro, "libssl1.1" if distro == "debian11" else "libssl3"), | |||
| deb_pkg(arch, distro, "openssl"), | |||
There was a problem hiding this comment.
I would prefer we remove openssl from debian12 images. It can be available in debug
cc/BUILD
Outdated
| @@ -10,6 +10,9 @@ DISTRO_DEBS = { | |||
| "debian11": [ | |||
There was a problem hiding this comment.
if there are the same, just put them in the tars section. I feel like this might be remnants from debian10 days, and doesn't appear to be necessary anymore.
Thanks, addressed all your feedback, could you please have another look? |
dahu33
commented
Aug 25, 2023
loosebazooka
approved these changes
Aug 28, 2023
|
Would love to see the java targets added as well. |
|
I think the language targets will be added slowly as we roll this out gradually. |
|
@loosebazooka thanks for the quick review!
@Sineaggi working on it, will see if I can get it out this week. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #1337 and might supersede #1365
Requires #1384 to build on a fresh setup.
This builds
base,static,base-nosslandccimages. Happy to work on the other targets after feedback from maintainers.