Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog changes for v0.15.1 #1075

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Oct 2, 2018

cc #1074

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@balopat
Copy link
Contributor Author

balopat commented Oct 2, 2018

cla should be fine, the commit is already merged: #1070

@codecov-io
Copy link

codecov-io commented Oct 2, 2018

Codecov Report

Merging #1075 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1075   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          72       72           
  Lines        3156     3156           
=======================================
  Hits         1321     1321           
  Misses       1706     1706           
  Partials      129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c01af...2e53f73. Read the comment docs.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit strange that the change also shows up here, but LGTM

@googlebot
Copy link

CLAs look good, thanks!

@balopat balopat merged commit 83da27e into GoogleContainerTools:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants