Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass context when listing dependencies #1108

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 8, 2018

Fixes #1104

@codecov-io
Copy link

codecov-io commented Oct 8, 2018

Codecov Report

Merging #1108 into master will not change coverage.
The diff coverage is 40%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1108   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files          84       84           
  Lines        3667     3667           
=======================================
  Hits         1617     1617           
  Misses       1895     1895           
  Partials      155      155
Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 50.2% <0%> (ø) ⬆️
pkg/skaffold/docker/image.go 59.18% <100%> (ø) ⬆️
pkg/skaffold/docker/parse.go 66.94% <100%> (ø) ⬆️
pkg/skaffold/bazel/bazel.go 91.3% <100%> (ø) ⬆️
pkg/skaffold/docker/context.go 31.03% <40%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f67b291...f06f8f4. Read the comment docs.

@dgageot dgageot merged commit eee79f1 into GoogleContainerTools:master Oct 9, 2018
@dgageot dgageot deleted the fix-1104 branch December 28, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants