Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves jib.getDependencies. #1125

Merged

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Oct 8, 2018

Resolves issues in #1096:

/cc @GoogleContainerTools/java-tools

@codecov-io
Copy link

Codecov Report

Merging #1125 into jib_skaffold will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           jib_skaffold   #1125      +/-   ##
===============================================
+ Coverage         43.84%   43.9%   +0.06%     
===============================================
  Files                81      81              
  Lines              3526    3530       +4     
===============================================
+ Hits               1546    1550       +4     
  Misses             1838    1838              
  Partials            142     142
Impacted Files Coverage Δ
pkg/skaffold/jib/jib.go 89.65% <100%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c55909b...8c68df0. Read the comment docs.

@dgageot dgageot merged commit 6f8ce4d into GoogleContainerTools:jib_skaffold Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants