Allow webhook to create a deployment #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2018 14:43
Adds support for creating a deployment which will map to a service with an external IP. The deployment consists of an init container and a regular container. The init container is responsible for copying the PR branch (with docs changes) into an emptyDir volume. The volume is then mounted into a container, which runs `hugo server -D --bind 0.0.0.0 --baseURL external-service-ip`. Once this deployment stabilizes, the static website reflecting changes to the docs should be availble at the external IP address associated with the service. Next steps include: 1. Commenting on the Github PR once the deployment is ready 2. Uploading logs to GCS and commenting on the Github PR with a link to those logs if the deployment should fail
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1227 +/- ##
=======================================
Coverage 41.49% 41.49%
=======================================
Files 95 95
Lines 4234 4234
=======================================
Hits 1757 1757
Misses 2307 2307
Partials 170 170Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for creating a deployment which will map to a service with
an external IP.
The deployment consists of an init container and a regular container.
The init container is responsible for copying the PR branch (with docs
changes) into an emptyDir volume. The volume is then mounted into a
container, which runs
hugo server -D --bind 0.0.0.0 --baseURL external-service-ip. Once this deployment stabilizes, the staticwebsite reflecting changes to the docs should be available at the
external IP address associated with the service.
Next steps include:
those logs if the deployment should fail
I also added
--tag $COMMIT_SHAto the cloudbuild release yaml because deployed images weren't being tagged with it automatically (currently the image running in cluster is tagged withdirty-6691c77)