Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples and release notes to use v1alpha5 #1244

Merged
merged 2 commits into from
Nov 7, 2018

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Nov 7, 2018

An accidental merge created an extra version upgrade causing v0.17.0 being out of sync with the examples folder on master and the changelog.
This commit fixes the inconsistency by upgrading the examples and changelog to v1alpha5.

Fixes #1235.

An accidental merge created an extra version upgrade causing v0.17.0 being out of sync with the examples folder on master and the changelog.
This commit fixes the inconsistency by upgrading the examples and changelog to v1alpha5.

Fixes GoogleContainerTools#1235.
@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #1244 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1244   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files          96       96           
  Lines        4237     4237           
=======================================
  Hits         1788     1788           
  Misses       2275     2275           
  Partials      174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d69cf...5d3183f. Read the comment docs.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the only time we have to do this :)

@dgageot dgageot merged commit 5cb8824 into GoogleContainerTools:master Nov 7, 2018
@balopat balopat deleted the fix_version_0170 branch November 7, 2018 18:24
@balopat balopat mentioned this pull request Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release notes for v0.17.0 report wrong config version
4 participants