Port forward multiple ports

[dgageot]

Fixes #1249

Signed-off-by: David Gageot [email protected]

[r2d4]

I think we still want to log the error? Maybe wrap this in a sync Group and return an error at the end if any of them errored (but still port forward?)

[dgageot]

@r2d4 Good point! Should be ok now

[codecov-io]

Codecov Report

Merging #1250 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1250      +/-   ##
==========================================
+ Coverage   42.18%   42.24%   +0.05%     
==========================================
  Files          96       96              
  Lines        4238     4242       +4     
==========================================
+ Hits         1788     1792       +4     
  Misses       2276     2276              
  Partials      174      174

Impacted Files	Coverage Δ
pkg/skaffold/kubernetes/port_forward.go	42.85% <100%> (+2.62%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0badfef...d0452a8. Read the comment docs.

[r2d4]

So if we port forward some but then fail and return an error, I’m not sure we’ll clean up the rest properly.

I guess this was also an issue before when the first port forward in a pod succeeded and the second one failed.

Let’s merge for now and keep an eye out for any forwards that don’t get cleaned up properly