Add additional flags to kaniko builder #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users to pass in any additional flags to the kaniko builder. This could include flags for insecure pulls/pushes, or the --single-snapshot flag which speeds up snapshotting (which I added to the local integration test).
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1387 +/- ##
==========================================
- Coverage 44.4% 44.39% -0.01%
==========================================
Files 109 109
Lines 4542 4543 +1
==========================================
Hits 2017 2017
- Misses 2319 2320 +1
Partials 206 206
Continue to review full report at Codecov.
|
dgageot
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users to pass in any additional flags to the kaniko
builder. This could include flags for insecure pulls/pushes, or the
--single-snapshot flag which speeds up snapshotting (which I added to
the local integration test).