Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements to kaniko builder #1426

Merged
merged 2 commits into from
Dec 27, 2018
Merged

Small improvements to kaniko builder #1426

merged 2 commits into from
Dec 27, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 26, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 26, 2018 •
edited
Loading

Codecov Report

Merging #1426 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1426      +/-   ##
=========================================
+ Coverage   44.78%   44.8%   +0.02%     
=========================================
  Files         111     111              
  Lines        4551    4551              
=========================================
+ Hits         2038    2039       +1     
+ Misses       2308    2307       -1     
  Partials      205     205
Impacted Files Coverage Δ
pkg/skaffold/build/kaniko/run.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/kaniko/kaniko.go 0% <0%> (ø) ⬆️
pkg/skaffold/watch/triggers.go 27.77% <0%> (-5.56%) ⬇️
pkg/skaffold/watch/watch.go 85% <0%> (-1.05%) ⬇️
pkg/skaffold/build/gcb/cloud_build.go 0% <0%> (ø) ⬆️
pkg/skaffold/runner/runner.go 61.48% <0%> (+0.26%) ⬆️
pkg/skaffold/build/local/local.go 55.31% <0%> (+0.97%) ⬆️
pkg/skaffold/runner/dev.go 52.77% <0%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a3404...abfecc7. Read the comment docs.

@balopat
Copy link
Contributor

balopat commented Dec 27, 2018

I restarted the kokoro build.
The error was weird - for the record - it might be a flake:

   --- FAIL: TestRun/kaniko_example (11.52s)
    	run_test.go:183: skaffold: Starting build...
    		Creating kaniko secret [e2esecret]...
    		Building [gcr.io/k8s-skaffold/skaffold-example]...
    		Uploading sources to skaffold-kaniko GCS bucket
    		INFO[0000] Downloading base image gcr.io/google-appengine/golang
    		INFO[0000] Downloading base image gcr.io/google-appengine/golang
    		WARN[0000] Error while retrieving image from cache: getting image from path: open /cache/sha256:d01a3252f0f104c6ecb156f495dbd924684a6946d48f2bec39ad1e7280a9f412: no such file or directory
    		INFO[0000] Using files from context: [/kaniko/buildcontext/main.go]
    		INFO[0000] Checking for cached layer gcr.io/k8s-skaffold/skaffold-example/cache:971cb6a5cc381db4ba9d5cd7a392efe10065f5475f5d0be62f30d0c3f1da25e7...
    		INFO[0000] Using caching version of cmd: RUN go build -o app main.go
    		INFO[0000] Taking snapshot of full filesystem...
    		INFO[0000] Skipping paths under /dev, as it is a whitelisted directory
    		INFO[0000] Skipping paths under /kaniko, as it is a whitelisted directory
    		INFO[0000] Skipping paths under /proc, as it is a whitelisted directory
    		INFO[0000] Skipping paths under /secret, as it is a whitelisted directory
    		INFO[0000] Skipping paths under /sys, as it is a whitelisted directory
    		INFO[0000] Skipping paths under /var/run, as it is a whitelisted directory
    		INFO[0000] WORKDIR /go/src/github.com/GoogleCloudPlatform/skaffold
    		INFO[0000] cmd: workdir
    		INFO[0000] Changed working directory to /go/src/github.com/GoogleCloudPlatform/skaffold
    		INFO[0000] Creating directory /go/src/github.com/GoogleCloudPlatform/skaffold
    		INFO[0000] Taking snapshot of files...
    		INFO[0000] CMD ["./app"]
    		INFO[0000] No files changed in this command, skipping snapshotting.
    		INFO[0000] Using files from context: [/kaniko/buildcontext/main.go]
    		INFO[0000] COPY main.go .
    		INFO[0000] Taking snapshot of files...
    		INFO[0000] RUN go build -o app main.go
    		INFO[0000] Found cached layer, extracting to filesystem
    		INFO[0000] Taking snapshot of files...
    		2018/12/26 14:37:16 existing blob: sha256:725ac7a019ef8af6a5672bd9a14aaba358f0716371496b9eeff9ceabb21abc64
    		2018/12/26 14:37:17 existing blob: sha256:98e03b0c98248ce7e0a4984cbde5e59be15e27984bc2a674a9d43247bd20109f
    		2018/12/26 14:37:17 existing blob: sha256:a21f4015913a12cddd687f0c0d9d908d66097da0a4085f85370c1a875d1051a2
    		2018/12/26 14:37:17 existing blob: sha256:588933cac1420f0754ff634f867098e4244b0196922b763758baf40653d131cf
    		2018/12/26 14:37:17 existing blob: sha256:5155db63ea8789b8d148cdf7991bf14ac6eb506221a05603c87b1dc4784e0757
    		2018/12/26 14:37:17 existing blob: sha256:4a517228710bb34d935053907b8e57807cf3d08926c3436244fb34bc5bf5844f
    		2018/12/26 14:37:17 existing blob: sha256:405c9a26ffac2488175dced8b011b39028c7ada642b3fcad4bba303bfecaa2a3
    		2018/12/26 14:37:18 pushed blob sha256:b8585328fe776fa26a9bf41c273838226508d1d9a8611cbbc852ed0fc951b5f1
    		2018/12/26 14:37:18 pushed blob sha256:1d7059eaccb6d30bdd17a753f254d9e43e59964d1949714e7782026a9175c03a
    		2018/12/26 14:37:18 pushed blob sha256:48d2cbc6151e520e8a6a344a94085c9b4167f88b6329ee63e69462bc9611e2fb
    		2018/12/26 14:37:18 pushed blob sha256:d99bc92f4dd7b3b7feb55050cf5c85899de02ddac91e1de62ea3ddc53388f2f7
    		2018/12/26 14:37:19 gcr.io/k8s-skaffold/skaffold-example:cb74e54a9d524840bdf73bac2b9b6ff7: digest: sha256:da86690e2d6de148195f0df045716cb23aa507acc95bb7cfa8a98082f68bd2c0 size: 1883
    		 Running [skaffold run --namespace skaffoldq5jj2]: stdout Starting build...
    		Creating kaniko secret [e2esecret]...
    		Building [gcr.io/k8s-skaffold/skaffold-example]...
    		Uploading sources to skaffold-kaniko GCS bucket
    		INFO[0000] Downloading base image gcr.io/google-appengine/golang
    		INFO[0000] Downloading base image gcr.io/google-appengine/golang
    		WARN[0000] Error while retrieving image from cache: getting image from path: open /cache/sha256:d01a3252f0f104c6ecb156f495dbd924684a6946d48f2bec39ad1e7280a9f412: no such file or directory
    		INFO[0000] Using files from context: [/kaniko/buildcontext/main.go]
    		INFO[0000] Checking for cached layer gcr.io/k8s-skaffold/skaffold-example/cache:971cb6a5cc381db4ba9d5cd7a392efe10065f5475f5d0be62f30d0c3f1da25e7...
    		INFO[0000] Using caching version of cmd: RUN go build -o app main.go
    		INFO[0000] Taking snapshot of full filesystem...
    		INFO[0000] Skipping paths under /dev, as it is a whitelisted directory
    		INFO[0000] Skipping paths under /kaniko, as it is a whitelisted directory
    		INFO[0000] Skipping paths under /proc, as it is a whitelisted directory
    		INFO[0000] Skipping paths under /secret, as it is a whitelisted directory
    		INFO[0000] Skipping paths under /sys, as it is a whitelisted directory
    		INFO[0000] Skipping paths under /var/run, as it is a whitelisted directory
    		INFO[0000] WORKDIR /go/src/github.com/GoogleCloudPlatform/skaffold
    		INFO[0000] cmd: workdir
    		INFO[0000] Changed working directory to /go/src/github.com/GoogleCloudPlatform/skaffold
    		INFO[0000] Creating directory /go/src/github.com/GoogleCloudPlatform/skaffold
    		INFO[0000] Taking snapshot of files...
    		INFO[0000] CMD ["./app"]
    		INFO[0000] No files changed in this command, skipping snapshotting.
    		INFO[0000] Using files from context: [/kaniko/buildcontext/main.go]
    		INFO[0000] COPY main.go .
    		INFO[0000] Taking snapshot of files...
    		INFO[0000] RUN go build -o app main.go
    		INFO[0000] Found cached layer, extracting to filesystem
    		INFO[0000] Taking snapshot of files...
    		2018/12/26 14:37:16 existing blob: sha256:725ac7a019ef8af6a5672bd9a14aaba358f0716371496b9eeff9ceabb21abc64
    		2018/12/26 14:37:17 existing blob: sha256:98e03b0c98248ce7e0a4984cbde5e59be15e27984bc2a674a9d43247bd20109f
    		2018/12/26 14:37:17 existing blob: sha256:a21f4015913a12cddd687f0c0d9d908d66097da0a4085f85370c1a875d1051a2
    		2018/12/26 14:37:17 existing blob: sha256:588933cac1420f0754ff634f867098e4244b0196922b763758baf40653d131cf
    		2018/12/26 14:37:17 existing blob: sha256:5155db63ea8789b8d148cdf7991bf14ac6eb506221a05603c87b1dc4784e0757
    		2018/12/26 14:37:17 existing blob: sha256:4a517228710bb34d935053907b8e57807cf3d08926c3436244fb34bc5bf5844f
    		2018/12/26 14:37:17 existing blob: sha256:405c9a26ffac2488175dced8b011b39028c7ada642b3fcad4bba303bfecaa2a3
    		2018/12/26 14:37:18 pushed blob sha256:b8585328fe776fa26a9bf41c273838226508d1d9a8611cbbc852ed0fc951b5f1
    		2018/12/26 14:37:18 pushed blob sha256:1d7059eaccb6d30bdd17a753f254d9e43e59964d1949714e7782026a9175c03a
    		2018/12/26 14:37:18 pushed blob sha256:48d2cbc6151e520e8a6a344a94085c9b4167f88b6329ee63e69462bc9611e2fb
    		2018/12/26 14:37:18 pushed blob sha256:d99bc92f4dd7b3b7feb55050cf5c85899de02ddac91e1de62ea3ddc53388f2f7
    		2018/12/26 14:37:19 gcr.io/k8s-skaffold/skaffold-example:cb74e54a9d524840bdf73bac2b9b6ff7: digest: sha256:da86690e2d6de148195f0df045716cb23aa507acc95bb7cfa8a98082f68bd2c0 size: 1883
    		, stderr: time="2018-12-26T14:37:25Z" level=fatal msg="build failed: building [gcr.io/k8s-skaffold/skaffold-example]: tagging image: UNAUTHORIZED: \"authentication required\""
    		, err: exit status 1: exit status 1

@balopat
Copy link
Contributor

balopat commented Dec 27, 2018

it seems these errors are pretty stable

@balopat balopat mentioned this pull request Dec 27, 2018
Closed
@dgageot
Rename main function
ee22429 
Signed-off-by: David Gageot <[email protected]>
@dgageot
Remove redundant argument
abfecc7 
Signed-off-by: David Gageot <[email protected]>
@dgageot
Copy link
Contributor Author

dgageot commented Dec 27, 2018

@balopat I removed the commit that introduced the issue

@dgageot dgageot merged commit cf877dc into GoogleContainerTools:master Dec 27, 2018
@dgageot dgageot deleted the small-improvements-kaniko branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@r2d4 r2d4 Awaiting requested review from r2d4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @codecov-io @balopat