Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload sources for any kind of artifact #1477

Merged
merged 5 commits into from
Jan 17, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 16, 2019

This is needed if we want to build Jib or Bazel artifacts on GCB

@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #1477 into master will increase coverage by 0.38%.
The diff coverage is 57.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1477      +/-   ##
=========================================
+ Coverage   44.42%   44.8%   +0.38%     
=========================================
  Files         112     112              
  Lines        4642    4638       -4     
=========================================
+ Hits         2062    2078      +16     
+ Misses       2373    2350      -23     
- Partials      207     210       +3
Impacted Files Coverage Δ
pkg/skaffold/build/deps.go 0% <ø> (ø)
pkg/skaffold/docker/context.go 71.42% <ø> (+40.39%) ⬆️
pkg/skaffold/build/gcb/cloud_build.go 0% <0%> (ø) ⬆️
pkg/skaffold/runner/dev.go 56.52% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/diagnose.go 0% <0%> (ø) ⬆️
pkg/skaffold/util/tar.go 38.46% <62.5%> (+21.48%) ⬆️
pkg/skaffold/docker/parse.go 74.88% <66.66%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fdb68b...9f666d3. Read the comment docs.

Signed-off-by: David Gageot <[email protected]>
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgageot dgageot merged commit 69776b1 into GoogleContainerTools:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants