Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coloured output when building in // #1501

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 20, 2019

Currently, the output for each build in buffered without colors.

Signed-off-by: David Gageot [email protected]

@codecov-io
Copy link

codecov-io commented Jan 21, 2019

Codecov Report

Merging #1501 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1501      +/-   ##
=========================================
- Coverage   44.87%   44.8%   -0.07%     
=========================================
  Files         115     115              
  Lines        4771    4778       +7     
=========================================
  Hits         2141    2141              
- Misses       2409    2415       +6     
- Partials      221     222       +1
Impacted Files Coverage Δ
pkg/skaffold/build/parallel.go 0% <0%> (ø) ⬆️
pkg/skaffold/color/formatter.go 80% <0%> (-8.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bcca6...87678e5. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1501 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1501      +/-   ##
=========================================
- Coverage   44.87%   44.8%   -0.07%     
=========================================
  Files         115     115              
  Lines        4771    4778       +7     
=========================================
  Hits         2141    2141              
- Misses       2409    2415       +6     
- Partials      221     222       +1
Impacted Files Coverage Δ
pkg/skaffold/build/parallel.go 0% <0%> (ø) ⬆️
pkg/skaffold/color/formatter.go 80% <0%> (-8.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bcca6...3fc58ef. Read the comment docs.

@nkubala nkubala merged commit 11b730e into GoogleContainerTools:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants