adding scripts for preparing new config version #1584
Conversation
balopat
requested review from
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
|
@balopat Sorry I forgot to take a look. Will do that tomorrow |
Codecov Report
@@ Coverage Diff @@
## master #1584 +/- ##
==========================================
+ Coverage 46.31% 47.01% +0.69%
==========================================
Files 117 117
Lines 5106 5118 +12
==========================================
+ Hits 2365 2406 +41
+ Misses 2508 2471 -37
- Partials 233 241 +8
Continue to review full report at Codecov.
|
hack/new_version.sh
Outdated
|
|
||
| sed -i pkg/skaffold/schema/latest/config.go -e "s;$CURRENT_VERSION;$NEW_VERSION;g" | ||
|
|
||
| find integration -name "skaffold.yaml" | xargs -I xx sed -i xx -e "s;$CURRENT_VERSION;$NEW_VERSION;g" |
There was a problem hiding this comment.
IMHO find/xargs should always be used with -print0/-0 in scripts.
find integration -name "skaffold.yaml" -print0 | xargs -0 -I xx sed -i xx -e "s;$CURRENT_VERSION;$NEW_VERSION;g"
There was a problem hiding this comment.
why always? in this case it's definitely a relative path operation and everything resolves nicely.
There was a problem hiding this comment.
ah ignore me - I misunderstood the flag.
There was a problem hiding this comment.
thanks for the recommendation 👍
try it out with
bash hack/new_version.sh, let me know what you think!@dgageot