Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't push all tags when sha256 builds just one #1634

Merged
merged 6 commits into from
Feb 10, 2019

Conversation

michaelfig
Copy link
Contributor

I don't yet know how to describe the problem, except for that sha256 sends thousands of pushes if you use it with an image that doesn't have its own tag.

Forcing the tag to :skaffold (:latest would work, too) makes it behave properly.

@codecov-io
Copy link

codecov-io commented Feb 9, 2019

Codecov Report

Merging #1634 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1634      +/-   ##
==========================================
+ Coverage    46.9%   46.95%   +0.05%     
==========================================
  Files         119      119              
  Lines        5134     5139       +5     
==========================================
+ Hits         2408     2413       +5     
  Misses       2478     2478              
  Partials      248      248
Impacted Files Coverage Δ
pkg/skaffold/build/tag/sha256.go 70% <100%> (+30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5862895...fcf1ed0. Read the comment docs.

pkg/skaffold/build/tag/sha256.go Outdated Show resolved Hide resolved
pkg/skaffold/build/tag/sha256.go Outdated Show resolved Hide resolved
@dgageot
Copy link
Contributor

dgageot commented Feb 9, 2019

@michaelfig Could you create a ticket with a procedure to reproduce? I couldn't reproduce the issue here.

@michaelfig
Copy link
Contributor Author

@dgageot working on finding a simple example for a new issue.

@michaelfig michaelfig changed the title Fix sha256 losing its mind without a tag Don't push all tags when sha256 builds just one Feb 10, 2019
@michaelfig
Copy link
Contributor Author

@dgageot #1638 describes this problem in detail, with minimal steps to reproduce.

On my system, I have a lot of tags on one image, so it's especially slow and onerous to push them all.

@dgageot dgageot merged commit cb013d9 into GoogleContainerTools:master Feb 10, 2019
@michaelfig michaelfig deleted the sha-latest branch February 10, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants