Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example of a Jib-Maven multi-module project #1676

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Add example of a Jib-Maven multi-module project #1676

merged 3 commits into from
Feb 21, 2019

Conversation

briandealwis
Copy link
Member

@briandealwis briandealwis commented Feb 20, 2019 •
edited
Loading

Towards #1299

PTAL @dgageot

@codecov-io
Copy link

codecov-io commented Feb 20, 2019 •
edited
Loading

Codecov Report

Merging #1676 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1676   +/-   ##
=======================================
  Coverage   47.46%   47.46%           
=======================================
  Files         122      122           
  Lines        5454     5454           
=======================================
  Hits         2589     2589           
  Misses       2604     2604           
  Partials      261      261

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7232809...2a1acd1. Read the comment docs.

@briandealwis briandealwis mentioned this pull request Feb 20, 2019
Closed
dgageot
dgageot suggested changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the examples must be copied in integration/examples too

@briandealwis
Copy link
Member Author

PTAL — copied into integration/examples too.

@dgageot dgageot merged commit cb51880 into GoogleContainerTools:master Feb 21, 2019
@briandealwis briandealwis deleted the jibmm branch February 22, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat left review comments

@dgageot dgageot dgageot approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@r2d4 r2d4 Awaiting requested review from r2d4

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@briandealwis @codecov-io @dgageot @balopat @googlebot