Add Initializer Interface to skaffold to support other deployers in skaffold init #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
tejal29
force-pushed
the
add_initializer_module
branch
2 times, most recently
from
3da9c35
to
d3a71d8
Compare
tejal29
force-pushed
the
add_initializer_module
branch
from
3ce11bf
to
5f0bd4e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1756 +/- ##
==========================================
+ Coverage 46.27% 46.46% +0.19%
==========================================
Files 137 140 +3
Lines 6492 6523 +31
==========================================
+ Hits 3004 3031 +27
- Misses 3188 3189 +1
- Partials 300 303 +3
Continue to review full report at Codecov.
|
balopat
changed the title
balopat
changed the title
balopat
reviewed
Mar 11, 2019
balopat
reviewed
Mar 11, 2019
pkg/skaffold/initializer/util.go
Outdated
| // IsSupportedKubernetesFormat is for determining if a file under a glob pattern | ||
| // is deployable file format. It makes no attempt to check whether or not the file | ||
| // is actually deployable or has the correct contents. | ||
| func IsSupportedKubernetesFormat(n string) bool { |
There was a problem hiding this comment.
Suggested change
| func IsSupportedKubernetesFormat(n string) bool { | |
| func IsSupportedKubernetesFileExtension(n string) bool { |
?
tejal29
force-pushed
the
add_initializer_module
branch
from
5f0bd4e
to
7aff98d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is implementing the Proposal mentioned in #1726
In this PR,
Moved all the Kubectl deployer specific code to "github.com/GoogleContainerTools/skaffold/pkg/skaffold/initializer/kubectl" module and added tests.
Moved all
skaffold initprocessing from cmd/skaffold/app/cmd/init.go to pkg/skaffold/initializer/init.go and corresponding tests.In order to keep the diff minimum, i have not refactored a lot of code in to modules. I will refactor funcs like "resolveDockerfileImages" or "processCLIArtifacts" as appropriate when i add other intializers.
Added tests for some utility functions.