removing goroutine leak #1871
Merged
removing goroutine leak #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
requested review from
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1871 +/- ##
==========================================
+ Coverage 49.47% 49.48% +<.01%
==========================================
Files 168 168
Lines 7353 7354 +1
==========================================
+ Hits 3638 3639 +1
Misses 3361 3361
Partials 354 354
Continue to review full report at Codecov.
|
priyawadhwa
approved these changes
Mar 23, 2019
ottonello
pushed a commit
to ottonello/skaffold
that referenced
this pull request
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1867.
We should add goroutine leak detection to our tests!
It looks like this fix ran 7 times here without an issue - hopefully it will get up to 10: https://travis-ci.org/GoogleContainerTools/skaffold/builds/510176794
Before, this broke on the first 4 trials.