Add folders to tarballs #1878
Merged
Add folders to tarballs #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `CreateTar` is passed a folder, it shouldn't complain. The code currently complains on Jib projects built with GCB because Jib list folders as dependencies. Signed-off-by: David Gageot <[email protected]>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1878 +/- ##
==========================================
- Coverage 49.9% 49.89% -0.01%
==========================================
Files 168 168
Lines 7354 7361 +7
==========================================
+ Hits 3670 3673 +3
- Misses 3328 3330 +2
- Partials 356 358 +2
Continue to review full report at Codecov.
|
balopat
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
CreateTaris passed a folder, it shouldn't complain. The code currently complains on Jib projects built with GCB because Jib list folders as dependencies.Signed-off-by: David Gageot [email protected]