Introduce RunContext object for passing necessary context to runner constructor methods #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
requested review from
balopat,
dgageot,
priyawadhwa and
r2d4
as code owners
…onstructor methods
|
concerns: NeedsPush is not used anywhere, Plugins are failing on kokoro. |
|
Plugins were failing due to the gob encoder not supporting embedded structs with zero exported fields. |
tejal29
reviewed
Apr 1, 2019
balopat
added a commit
that referenced
this pull request
Apr 3, 2019
This should be a functionally equivalent change, i.e refactoring, however it does change the generated schema for the skaffold config Motivation: while introducing `RunContext` in #1885, it would be beneficial to just share the `Pipeline` part of the configuration, as: - no further functionality depends on the profiles/apiVersion/kind fields anyway - the profiles struct is not serializable by gob.encoder as it embeds `yamlpatch.Node` which does not have exported fields Changes: * extracting Pipeline struct fromSkaffoldConfig (SkaffoldPipeline originally) as an inline struct * changing top level schema definition to be the first defined struct instead of SkaffoldPipeline hardcoded
Codecov Report
@@ Coverage Diff @@
## master #1885 +/- ##
=========================================
- Coverage 49.83% 49.8% -0.03%
=========================================
Files 177 180 +3
Lines 8114 8149 +35
=========================================
+ Hits 4044 4059 +15
- Misses 3688 3708 +20
Partials 382 382
Continue to review full report at Codecov.
|
tejal29
approved these changes
Apr 3, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a refactor that adds a new configuration object,
RunContext, created by the runner. This object aggregates all contextual information about a skaffold pipeline run, and passes this object to all the constructors for the major components inside the runner (e.g.Builder,Deployer, etc.). This simplifies the constructor API, making it easier to add new parameters to these methods without having to change their signatures.One small functional change: the
Testernow optionally consumes the list of pre-built images (passed via the command line) from theSkaffoldOptionsobject, and uses this list to check against providedTestCases from the skaffold.yaml when running tests. This is a cleaner way of skipping tests for pre-built images.All other skaffold functionality should be unaffected by this change.