-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing non-oneof inline struct handling in schemas #1904
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
==========================================
+ Coverage 49.46% 49.47% +0.01%
==========================================
Files 174 174
Lines 8036 8038 +2
==========================================
+ Hits 3975 3977 +2
Misses 3683 3683
Partials 378 378
Continue to review full report at Codecov.
|
I just realized that with this change we have to add "oneOf" tag to all the oneOf fields in old schema versions as well - I'll do that soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few other test scenarios:
- What if an Inline Struct is a combination of oneof and other fields? shd this result as an error
- Inline Struct contains another Inline?
this should be validated by schema unit tests - they are not currently tested.
I would think this wouldn't work with schemagen yet, but haven't tried it - we should create an issue to explore/cover/validate against this edge case but doesn't belong to this PR. |
Fixes #1900, #1901.
And adds unit tests for schema generation + zero-type checking in
skaffold fix
(fixing a panic case).