Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message when the skaffold.yaml is not found #1947

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Fix error message when the skaffold.yaml is not found #1947

merged 3 commits into from
Apr 16, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 11, 2019

Fixes #1942

@dgageot dgageot force-pushed the fix-1942 branch 4 times, most recently from 16e2ac0 to 281ee2e Compare April 12, 2019 18:47
@nkubala
Copy link
Contributor

nkubala commented Apr 12, 2019

+1 from me, looks like one of your test cases needs to be updated though.

@dgageot dgageot marked this pull request as ready for review April 12, 2019 20:21
@dgageot
Copy link
Contributor Author

dgageot commented Apr 12, 2019

@nkubala should be good now

@balopat balopat merged commit 782c111 into GoogleContainerTools:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@r2d4 r2d4 Awaiting requested review from r2d4

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message could be better when skaffold.yaml is not found
4 participants
@dgageot @nkubala @balopat @googlebot