Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze v1beta8 skaffold config #1965

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

corneliusweig
Copy link
Contributor

There are upcoming config changes.

@codecov-io
Copy link

codecov-io commented Apr 16, 2019

Codecov Report

Merging #1965 into master will increase coverage by 0.06%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1965      +/-   ##
==========================================
+ Coverage   52.52%   52.59%   +0.06%     
==========================================
  Files         180      182       +2     
  Lines        7865     7893      +28     
==========================================
+ Hits         4131     4151      +20     
- Misses       3348     3352       +4     
- Partials      386      390       +4
Impacted Files Coverage Δ
pkg/skaffold/schema/versions.go 69.23% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta7/upgrade.go 66.66% <ø> (ø) ⬆️
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta8/config.go 100% <100%> (ø)
pkg/skaffold/schema/v1beta8/upgrade.go 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5880849...4d2b931. Read the comment docs.

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Apr 16, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 16, 2019
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nkubala nkubala merged commit fc22668 into GoogleContainerTools:master Apr 16, 2019
@corneliusweig corneliusweig deleted the freeze-v1beta8 branch April 16, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants