-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve nodejs example to show subdirectories sync #2024
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #2024 +/- ##
==========================================
+ Coverage 55.96% 56.03% +0.07%
==========================================
Files 173 175 +2
Lines 7566 7615 +49
==========================================
+ Hits 4234 4267 +33
- Misses 2928 2940 +12
- Partials 404 408 +4 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
Looks like there is documentation around this feature, and skaffold.dev should be updated after the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, one thing to fix -- could you make these changes in integration/examples/nodejs
instead of examples/nodejs
? The way we handle config changes requires this.
@priyawadhwa should be fixed now! |
@Ilyes-Hammadi , can you make the change in both files? so they are in both dir |
@tejal29 The changes are now in both folders. |
I've updated the
nodejs
example to show the use of the undocumentedfolder/***
sync feature that syncs subdirectories. My changes consist of just placing the javascript files in multiple folders and to get the attention of the developer learningskaffold
to pay attention when checking theskaffold.yaml
file on the difference between thefolder/**
andfolder/***
sync mechanisms.