-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare to Add functionality to Replacer interface to restrict setting labels on certain kinds. #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hold, until #2074 is merged since this depends on this. |
…els should be added
763a6e3
to
b5536b5
Compare
Codecov Report
|
b5536b5
to
48e1390
Compare
48e1390
to
3a20c62
Compare
3a20c62
to
cf2ac07
Compare
@dgageot Please take a look. This is ready for review. |
…preserve order" This reverts commit c9b5d08.
dgageot
approved these changes
Sep 11, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1737 and other deploy issues where labels get added to wrong CRDs.
In this PR, i added a Matcher Interface which is used by replacer to replace objects on a manifest key if it is present.
If the manifest object blob contains a match-key and its value is not matched, then we move to the the next Manifest object blob.
In this PR, i have introduced a new interface. This does not change in functionality.
Currently, all replacers
namespaceCollector
,labelsSetter
,imageSaver
andimageReplacer
use theanyMatcher
which match everything.The next steps for this feature would be
KindMatcher
which will match keykind
with valuesPod
,Deployment
andServices
(deployed Resources)KindMatcher
forlabelSetter