Remove copy paste deploy_test.go #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
requested review from
balopat,
dgageot,
nkubala and
priyawadhwa
as code owners
priyawadhwa
approved these changes
May 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #2085 +/- ##
=======================================
Coverage 56.11% 56.11%
=======================================
Files 180 180
Lines 7755 7755
=======================================
Hits 4352 4352
Misses 2987 2987
Partials 416 416Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added it with an intention to write tests for deploy #2001
However, there wasnt much scope for unit testing so i wrote an integration test.
Forgot to remove this copy paste