@ #1379 | Bug fix for Helm imageStrategy file sync

[hoatle]

fix for #1379

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[hoatle]

I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[codecov-io]

Codecov Report

Merging #2111 into master will decrease coverage by 4.21%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2111      +/-   ##
==========================================
- Coverage   60.59%   56.37%   -4.22%     
==========================================
  Files         185      180       -5     
  Lines        7806     7794      -12     
==========================================
- Hits         4730     4394     -336     
- Misses       2687     2982     +295     
- Partials      389      418      +29

Impacted Files	Coverage Δ
pkg/skaffold/deploy/helm.go	65.02% <100%> (+1.56%)	⬆️
pkg/skaffold/test/structure/types.go	0% <0%> (-100%)	⬇️
pkg/skaffold/kubernetes/watcher.go	0% <0%> (-100%)	⬇️
pkg/skaffold/test/structure/structure.go	0% <0%> (-100%)	⬇️
pkg/skaffold/test/test.go	14.7% <0%> (-85.3%)	⬇️
pkg/skaffold/kubernetes/wait.go	0% <0%> (-46.06%)	⬇️
pkg/skaffold/schema/v1alpha4/upgrade.go	58.62% <0%> (-41.38%)	⬇️
pkg/skaffold/build/cluster/sources/localdir.go	0% <0%> (-40.43%)	⬇️
pkg/skaffold/schema/v1alpha5/upgrade.go	64.7% <0%> (-35.3%)	⬇️
pkg/skaffold/schema/v1beta7/upgrade.go	66.66% <0%> (-33.34%)	⬇️
... and 90 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c41316c...5a77a65. Read the comment docs.

[balopat]

Thanks for opening getting started on this!

1. Do you mind adding a test to cover this?
2. I would love to see the a bit more evidence that this is a fix for Skaffold failing to sync with helm #1379 - do you mind adding more step by step detail how this is connected to sync error / fqn vs not fqn?
   Thank you!

[dgageot]

Hi @hoatle! Do you need some help to finish this PR?

[hoatle]

Hi @balopat @dgageot,
I added the example of helm deployment with hot reload.

• Before the fix:

...
Deploy complete in 977.47843ms
Watching for changes every 1s...
Syncing 1 files for docker.io/hoatle/gcr_io_k8s-skaffold_skaffold-helm-hot-reload:v0.31.0-35-gfb352b22-dirty@sha256:97f09bbb1956c3036c09555bae229d61f5bb546145e205c8dcc3130db4cb1445
WARN[0028] Skipping deploy due to sync error: copying files: didn't sync any files 
Watching for changes every 1s...

• After the fix:

...
Deploy complete in 1.002408729s
Watching for changes every 1s...
Syncing 1 files for docker.io/hoatle/gcr_io_k8s-skaffold_skaffold-helm-hot-reload:v0.31.0-35-gfb352b22-dirty@sha256:1eaf3b3dfc86552be2cea541bd3983096a6ac074007c0a1252c34bc46e47848d
Watching for changes every 1s...

I hope that the example will help to clarify the problem.

[georgekarrv]

👍 would love to have this in a release

[dgageot]

Hi @hoatle since you added a sample to the examples directory, you should also make sure that a copy of it is added to integration/examples. The version in examples should use the latest released version of the schema. The version in integration/examples should use the future schema version.

[dgageot]

See my comment

[dgageot]

@hoatle any chance you could update this PR?

[tejal29]

@hoatle, this got fixed in #1379

[tejal29]

Please remove the extractTag code change and move the examples/helm-deployment-hot-reloadtointegration/examples/helm-deployment-hot-reload`

[tejal29]

closing due to inactivity. Also the code change was fixed in another PR