Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add option --no-prune-children #2113

Merged
merged 1 commit into from
May 15, 2019
Merged

✨ Add option --no-prune-children #2113

merged 1 commit into from
May 15, 2019

Conversation

charlyx
Copy link
Contributor

@charlyx charlyx commented May 12, 2019

Hi 👋

This PR adds --no-prune-children flag.
I hope it meets issue #2050 expectations.

I'm not sure the description of the flag I made is OK though...
I'll be happy with suggestions.

@codecov-io
Copy link

codecov-io commented May 12, 2019 •
edited
Loading

Codecov Report

Merging #2113 into master will decrease coverage by 0.01%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2113      +/-   ##
==========================================
- Coverage   56.29%   56.28%   -0.02%     
==========================================
  Files         180      180              
  Lines        7794     7798       +4     
==========================================
+ Hits         4388     4389       +1     
- Misses       2989     2992       +3     
  Partials      417      417
Impacted Files Coverage Δ
pkg/skaffold/config/options.go 90.47% <ø> (ø) ⬆️
pkg/skaffold/docker/image_util.go 0% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/cmd.go 74.25% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbfc033...000b188. Read the comment docs.

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label May 13, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 13, 2019
balopat
balopat approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this LGTM, can you please rebase?

@charlyx charlyx force-pushed the issue-2050-prune-children-config branch from c3f78da to 000b188 Compare May 14, 2019 17:35
@charlyx
Copy link
Contributor Author

charlyx commented May 14, 2019

@balopat done 👌

@priyawadhwa priyawadhwa added kokoro:run runs the kokoro jobs on a PR and removed needs-rebase labels May 14, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 14, 2019
@nkubala
Copy link
Contributor

nkubala commented May 15, 2019

@charlyx thanks for this one!

@nkubala nkubala merged commit f8da7a5 into GoogleContainerTools:master May 15, 2019
@nkubala nkubala mentioned this pull request May 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@charlyx @codecov-io @nkubala @balopat @googlebot @priyawadhwa @kokoro-team