Always use the same technic to cleanup global variables in tests. #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not pretty but it's more compact and after a while become yet another Go idiom that you just recognize at first sight. Signed-off-by: David Gageot <[email protected]>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2135 +/- ##
=======================================
Coverage 56.31% 56.31%
=======================================
Files 180 180
Lines 7815 7815
=======================================
Hits 4401 4401
Misses 2994 2994
Partials 420 420Continue to review full report at Codecov.
|
tejal29
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not pretty but it's more compact and after a while become
yet another Go idiom that you just recognize at first sight.
Signed-off-by: David Gageot [email protected]