Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some old plugin related code from event handler #2156

Merged
merged 1 commit into from
May 21, 2019

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented May 20, 2019

no functional change

@codecov-io
Copy link

Codecov Report

Merging #2156 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2156      +/-   ##
=========================================
+ Coverage   56.74%   56.8%   +0.06%     
=========================================
  Files         183     183              
  Lines        7860    7848      -12     
=========================================
- Hits         4460    4458       -2     
+ Misses       2988    2980       -8     
+ Partials      412     410       -2
Impacted Files Coverage Δ
pkg/skaffold/event/event.go 91.6% <100%> (+5.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9916f...4b94078. Read the comment docs.

@dgageot dgageot merged commit fb7c2a4 into GoogleContainerTools:master May 21, 2019
@nkubala nkubala deleted the remove-plugin-event branch June 12, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants