Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand values file paths prefixed with ~ #2233

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Expand values file paths prefixed with ~ #2233

merged 2 commits into from
Jun 10, 2019

Conversation

cedrickring
Copy link
Contributor

Fixes #2123

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Jun 8, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 8, 2019
dgageot
dgageot suggested changes Jun 8, 2019
View reviewed changes
pkg/skaffold/deploy/helm_test.go Outdated Show resolved Hide resolved
@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Jun 10, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 10, 2019
balopat
balopat approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you!!

@nkubala nkubala merged commit db2274b into GoogleContainerTools:master Jun 10, 2019
@cedrickring cedrickring deleted the expand-paths branch June 11, 2019 17:58
@michaelmohamed michaelmohamed mentioned this pull request Dec 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@dgageot dgageot dgageot approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skaffold helm valuesFiles does not handle tilde sign
6 participants
@cedrickring @dgageot @balopat @googlebot @nkubala @kokoro-team