-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jib detection to skaffold init #2276
Merged
dgageot
merged 49 commits into
GoogleContainerTools:master
from
TadCordle:jib-skaffold-init
Jul 30, 2019
Merged
Add Jib detection to skaffold init #2276
dgageot
merged 49 commits into
GoogleContainerTools:master
from
TadCordle:jib-skaffold-init
Jul 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d into jib-skaffold-init
…d into jib-skaffold-init
…d into jib-skaffold-init
…d into jib-skaffold-init
Codecov Report
|
…kaffold into jib-skaffold-init
…kaffold into jib-skaffold-init
…kaffold into jib-skaffold-init
…kaffold into jib-skaffold-init
chanseokoh
reviewed
Jul 17, 2019
chanseokoh
reviewed
Jul 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
chanseokoh
approved these changes
Jul 29, 2019
dgageot
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review after #2327.
This PR adds Jib detection to
skaffold init
. Skaffold walks the directory searching for dockerfiles,build.gradle
s, andpom.xml
s. If abuild.gradle
or apom.xml
is found, skaffold will attempt to run an internal Jib gradle task/maven goal to determine if Jib is configured on any of the projects (Jib v1.3.0 or higher is required for this to work).If Jib is detected and
jib.to.image
is configured with an image found in the k8s manifest, the Jib builder is added to the skaffold config automatically.If Jib is detected but
jib.to.image
is not configured to build a k8s image, the Jib project is added to the CLI prompt so the user can decide which image Jib should build, and the user's choice is added using the-Djib.to.image=...
flag.Issues left to solve:
Towards #1264 (probably not completely fixed until there's some idea how to automatically apply Jib to maven/gradle projects).