Improve and test the notify trigger #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgageot
commented
Jun 20, 2019
•
dgageot
commented
- Mitigate the case where we miss the first change event
- Add unit test
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
nkubala
reviewed
Jun 20, 2019
Gopkg.toml
Outdated
| @@ -73,7 +73,8 @@ | |||
|
|
|||
| [[constraint]] | |||
| name = "github.com/rjeczalik/notify" | |||
| version = "0.9.2" | |||
| revision = "9ace999fc73bca667fd45dafc41356186f8b7e65" | |||
| source = "https://github.com/dgageot/notify.git" | |||
There was a problem hiding this comment.
can you add a comment here explaining what you fixed and why we're using your fork?
also, did you send a PR? :)
There was a problem hiding this comment.
I’ll do that! Thanks!
There was a problem hiding this comment.
In fact, with the mitigation code, I might get rid of the fork!
There was a problem hiding this comment.
I got rid of the fork
Codecov Report
|
balopat
suggested changes
Jun 21, 2019
pkg/skaffold/watch/triggers.go
Outdated
| @@ -175,8 +180,11 @@ func (t *fsNotifyTrigger) Start(ctx context.Context) (<-chan bool, error) { | |||
| timer.Reset(t.Interval) | |||
| case <-timer.C: | |||
| trigger <- true | |||
| case <-initialTimer.C: | |||
| trigger <- true | |||
There was a problem hiding this comment.
shouldn't we have an initialTimer.Stop() here as well to trigger it only once?
balopat
approved these changes
Jun 21, 2019
Add unit test for the notify trigger Signed-off-by: David Gageot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.