Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaniko: fix host path support #2333

Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 25, 2019

@priyawadhwa Can you TAL? I think this was broken but I'm not sure

Signed-off-by: David Gageot [email protected]

Signed-off-by: David Gageot <[email protected]>
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #2333 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/build/cluster/kaniko.go 43.28% <100%> (+2.98%) ⬆️

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this was broken, thanks for fixing!

@priyawadhwa priyawadhwa merged commit 9bbb4b4 into GoogleContainerTools:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants