Fix handling of multi stage builds #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gageot <[email protected]>
Fixes GoogleContainerTools#2315 Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
It will fail anyways when getting the WORKDIR. This simplifies the tests because now, we can just let them fail if they try to fetch an unknown image. Signed-off-by: David Gageot <[email protected]>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
This was referenced Jun 26, 2019
Closed
nkubala
reviewed
Jun 26, 2019
nkubala
approved these changes
Jun 26, 2019
valery-vitko
added a commit
to Steinpilz/docker
that referenced
this pull request
Jun 27, 2019
Downgrade to a previous version until fix for multi stage Docker builds released (GoogleContainerTools/skaffold#2340).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2315