Increase test coverage on Jib Builder #2383
Conversation
dgageot
requested review from
balopat,
briandealwis,
chanseokoh,
loosebazooka,
nkubala,
priyawadhwa,
TadCordle and
tejal29
as code owners
Codecov Report
|
Signed-off-by: David Gageot <[email protected]>
| { | ||
| description: "local build", | ||
| artifact: &latest.JibGradleArtifact{}, | ||
| cmd: testutil.FakeRun(t, "gradle -Djib.console=plain :jibDockerBuild --image=img:tag"), |
There was a problem hiding this comment.
I'm not sure how this testing framework works: Are we verifying that the code creates the command defined in FakeRun "gradle -Djib.console=plain :jibDockerBuild --image=img:tag"?
There was a problem hiding this comment.
It’s checking that command and only this one runs
There was a problem hiding this comment.
kinda like a Mockito.when().then()?
|
@TadCordle should be good now. Thanks for the review! |
| { | ||
| description: "local build", | ||
| artifact: &latest.JibGradleArtifact{}, | ||
| cmd: testutil.FakeRun(t, "gradle -Djib.console=plain :jibDockerBuild --image=img:tag"), |
There was a problem hiding this comment.
kinda like a Mockito.when().then()?
|
Don’t worry, I’m working on the remote case but I’d rather get this merged first |
|
Is jib team not owners? |
|
That would make sense but the file pattern |
Signed-off-by: David Gageot [email protected]