Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test regexp usage in profiles activation #2417

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Test regexp usage in profiles activation #2417

merged 2 commits into from
Jul 9, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 5, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jul 5, 2019 •
edited
Loading

Codecov Report

Merging #2417 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/schema/profiles.go 88.43% <100%> (+2.22%) ⬆️

@dgageot dgageot changed the title Test regexp usage in profiles acticvation Test regexp usage in profiles activation Jul 5, 2019
@balopat balopat merged commit 6e6af45 into GoogleContainerTools:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @balopat @googlebot