Fix proto generation and testing #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
dgageot
force-pushed
the
fix-proto-testing
branch
from
0c48560 to
8c02f3b
Compare
nkubala
previously approved these changes
Jul 10, 2019
hack/generate-proto.sh
Outdated
| docker run $CONTAINER_NAME cat pkg/skaffold/server/proto/skaffold.pb.gw.go > proto/skaffold.pb.gw.go | ||
| export CONTAINER_NAME=generate-proto | ||
| docker build -t $CONTAINER_NAME -f hack/proto/Dockerfile --target generateFiles proto | ||
| docker run --rm $CONTAINER_NAME cat pkg/skaffold/server/proto/skaffold.pb.go > proto/skaffold.pb.go |
There was a problem hiding this comment.
why are the proto files getting generated into pkg/skaffold/server? they've been moved out into their own proto package right?
nkubala
dismissed
their stale review
didn't mean to hit approve when i submitted my comment
Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
fix-proto-testing
branch
from
8c02f3b to
3fb44c0
Compare
nkubala
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot [email protected]