Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to notify trigger #2482

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Default to notify trigger #2482

merged 1 commit into from
Jul 16, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 16, 2019

Fixes #1566

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #2482 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/dev.go 84.61% <100%> (ø) ⬆️

balopat
balopat approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@balopat balopat merged commit b847545 into GoogleContainerTools:master Jul 16, 2019
@yolkov
Copy link

yolkov commented Jul 24, 2019 •
edited
Loading

'notify' not working for Docker Desktop for Mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make notify based trigger the default
4 participants
@dgageot @yolkov @balopat @googlebot