Negotiate docker API version when creating minikube docker client #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
requested review from
balopat,
dgageot,
priyawadhwa and
tejal29
as code owners
nkubala
force-pushed
the
minikube-api-version
branch
from
2cc03d5 to
95d69e7
Compare
balopat
approved these changes
Jul 30, 2019
Codecov Report
|
1 similar comment
Codecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've been using the minikube docker-env to get the API version for our docker client in skaffold, and if this isn't set (which it isn't by default), we use the default API version in the client library. the issue is that recently, we updated our docker client dependency, which defaults to API version 1.40, but the default server version in minikube is somewhere around 1.39 so they're incompatible. let's just use the docker client API to do the negotiation for us.