Add unit test for LoadOrStore #2649
Conversation
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
|
| @@ -101,6 +101,14 @@ func TestForwardedPorts(t *testing.T) { | |||
| t.Fatal("didn't load port 9000 correctly") | |||
| } | |||
|
|
|||
| if _, ok := pf.LoadOrStore(4000, struct{}{}); ok { | |||
There was a problem hiding this comment.
I know this isn't directly related to this change, but it got me thinking. do we really need the signature of this method to take a struct{}{} at all? aren't we just using this as an atomic set to track which ports are in use? maybe we could just change the signature to LoadOrStore(value int) and have the implementation throw the struct{}{} in there. WDYT?
There was a problem hiding this comment.
So this is necessary because the forwardedPorts type has to implement the ForwardedPorts interface so that it can use GetAvailablePort.
I think the event API uses that function as well, except with a sync.Map, so we need LoadOrStore as written to work for both!
Adds unit test to LoadOrStore which had a bug in it previously
Part of #2596