Don't look up services in all namespaces. #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
requested review from
balopat,
dgageot,
nkubala and
priyawadhwa
as code owners
priyawadhwa
reviewed
Aug 14, 2019
There was a problem hiding this comment.
LGTM -- I think we just need to get namespaces from user defined port forwarding, which I added here along with unit tests.
that way people can still port forward additional resources which skaffold didn't deploy.
|
hmm, for user defined port forwarding, why do we need to fetch it? We should be able to get the specific resource right? |
|
ah that's true, nevermind! |
Codecov Report
|
priyawadhwa
reviewed
Aug 14, 2019
| }, | ||
| }, | ||
| }, { | ||
| description: "services present but does not expose any port", |
There was a problem hiding this comment.
is this possible for a service?
There was a problem hiding this comment.
you wont normally do it. But yes, you can not have any ports defined in the Spec and the service is created.
$ kubectl apply -f microservices/leeroy-app/kubernetes/
service/leeroy-app created
deployment.apps/leeroy-app created
$ git diff microservices/leeroy-app/kubernetes/
diff --git a/examples/microservices/leeroy-app/kubernetes/deployment.yaml b/examples/microservices/leeroy-app/kubernetes/deployment.yaml
index 56ef7152..46feab6d 100644
--- a/examples/microservices/leeroy-app/kubernetes/deployment.yaml
+++ b/examples/microservices/leeroy-app/kubernetes/deployment.yaml
@@ -6,9 +6,6 @@ metadata:
app: leeroy-app
spec:
clusterIP: None
- ports:
- - port: 50051
- name: leeroy-app
selector:
app: leeroy-app
---
tejaldesai@@examples (move_resolve_namespace)$
This was referenced Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2495,
In #2640, i made changes to collect all namespaces for deployed resources.
In PR, we go through all namespaces in the context and then look for services in each namespace.