Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the concepts section into several sub-pages #2810

Merged

Conversation

corneliusweig
Copy link
Contributor

This PR splits the concepts section into several sub-pages. Each section with a heading of the original version was extracted into a separate page. This works nicely for most sub-pages, but may be too much for the "Workflow" page, which is really small now. Maybe merge that one with "Architecture"? WDYT?

Also, we could revisit the item order here. I changed it from

  • Skaffold pipeline
  • Skaffold config
  • Workflow
  • Image repository handling
  • Architecture
  • Operating modes
  • Local development

to

  • Workflow
  • Architecture
  • Operating modes
  • Skaffold pipeline
  • Skaffold config
  • Local development
  • Image repository handling

Close #2779

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #2810 into master will not change coverage.
The diff coverage is n/a.

@balopat balopat added docs-modifications runs the docs preview service on the given PR kokoro:run runs the kokoro jobs on a PR labels Sep 5, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 5, 2019
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Sep 5, 2019
@container-tools-bot
Copy link

Please visit http://34.94.233.95:1313 to view changes to the docs.

@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like what you did - the reordering as well as the splitting - I don't think that the workflow page is too small - and we can always make it bigger :) Thank you!!!

@balopat balopat merged commit 76bf882 into GoogleContainerTools:master Sep 5, 2019
@corneliusweig corneliusweig deleted the w/restructure-concepts branch September 5, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Split concepts section into subpages
5 participants