Fix portforward flake #2824
Merged
Fix portforward flake #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
requested review from
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
balopat
commented
Sep 6, 2019
| @@ -315,21 +315,22 @@ func assertResponseFromPort(t *testing.T, port int, expected string) { | |||
| case <-ctx.Done(): | |||
| t.Fatalf("Timed out waiting for response from port %d", port) | |||
| case <-time.After(1 * time.Second): | |||
| resp, err := http.Get(fmt.Sprintf("http://%s:%d", util.Loopback, port)) | |||
| client := http.Client{Timeout: 1 * time.Second} | |||
There was a problem hiding this comment.
this is the fix - I expect that sometimes the client would just hang in broken connections causing the flake. This helps get over that issue and forces a retry.
Codecov Report
|
dgageot
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2787.