-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deployment
resource struct.
#2847
Conversation
} | ||
|
||
func (d *Deployment) String() string { | ||
return fmt.Sprintf("%s:%s/%s", d.namespace, d.rType, d.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will print test:deployment/leeroy-app
where test
is namespace and leeroy-app
is deployment name
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Add
Deployment
resource struct and use that instead of usingmap[string]Deadline
for tracking resources.Pass the same object to print summary.
The summary will now print the namespace of the object
Output change:
Before: skaffold run --default-repo gcr.io/tejal-test --status-check --namespac=test
After: