Always add image flag to jib builders in skaffold init #2854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2852
skaffold init
used to use Jib's configuredto.image
to auto-pair Jib projects with k8s images. However, the skaffold.yaml that was generated prioritized theto.image
configuration over the k8s images, possibly resulting in a skaffold.yaml that points a Jib builder to an image that isn't defined in a k8s manifest. This PR fixes that by only using k8s images in the generated artifacts, and also always explicitly passing a-Dimage=
flag to Jib to make sure it builds the correct image, despite its configuration.@GoogleContainerTools/java-tools-build