Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all docs have TOC on the right hand side. #3064

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Oct 15, 2019

Relates to #3023, #3024.

Description

  • make all docs have a toc on the right.
  • Add links to operating modes in deprecation Table.
  • Fix link in Build packs doc

User facing changes

See docs preview url.

Next PRs.

n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes
n/a

…n deprecation Table. Fix link in Build packs doc
@tejal29 tejal29 changed the title make all docs have a toc on the right. Add links to operating modes i… Make all docs have TOC on the right hand side. Oct 15, 2019
@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Oct 15, 2019
@container-tools-bot
Copy link

Please visit http://35.236.38.41:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 15, 2019
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - we just need to make sure we keep using relref everywhere for better link validation

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #3064 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/build/cluster/logs.go 16.66% <0%> (-3.34%) ⬇️
pkg/skaffold/build/bazel/dependencies.go 78.43% <0%> (-2.34%) ⬇️
cmd/skaffold/app/cmd/config.go 100% <0%> (ø) ⬆️
pkg/skaffold/build/parallel.go 94.36% <0%> (ø) ⬆️
pkg/skaffold/build/local/local.go 33.33% <0%> (ø) ⬆️
pkg/skaffold/jib/jib_gradle.go 100% <0%> (ø) ⬆️
pkg/skaffold/build/custom/dependencies.go 83.33% <0%> (ø) ⬆️
pkg/skaffold/build/cluster/secret.go 36.2% <0%> (ø) ⬆️
pkg/skaffold/debug/debug.go 43.33% <0%> (ø) ⬆️
pkg/skaffold/build/custom/custom.go 62.5% <0%> (ø) ⬆️
... and 75 more

@tejal29 tejal29 merged commit 9038a8d into GoogleContainerTools:master Oct 16, 2019
@tejal29 tejal29 deleted the add_toc branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants