-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all docs have TOC on the right hand side. #3064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n deprecation Table. Fix link in Build packs doc
tejal29
requested review from
balopat,
dgageot,
nkubala and
priyawadhwa
as code owners
October 15, 2019 22:03
tejal29
changed the title
make all docs have a toc on the right. Add links to operating modes i…
Make all docs have TOC on the right hand side.
Oct 15, 2019
tejal29
added
the
docs-modifications
runs the docs preview service on the given PR
label
Oct 15, 2019
Please visit http://35.236.38.41:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
runs the docs preview service on the given PR
label
Oct 15, 2019
balopat
reviewed
Oct 16, 2019
balopat
reviewed
Oct 16, 2019
balopat
reviewed
Oct 16, 2019
balopat
suggested changes
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - we just need to make sure we keep using relref
everywhere for better link validation
balopat
approved these changes
Oct 16, 2019
Codecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3023, #3024.
Description
User facing changes
See docs preview url.
Next PRs.
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
examples
dir, please copy them tointegration/examples
integration/examples
dir, should be tested in integration testReviewer Notes
Release Notes
n/a