Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Custom] [Deprecation] Use $IMAGE instead of $IMAGES #3084

Merged
merged 1 commit into from
Oct 21, 2019
Merged

[Custom] [Deprecation] Use $IMAGE instead of $IMAGES #3084

merged 1 commit into from
Oct 21, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 18, 2019 •
edited
Loading

Fixes #3081

$IMAGES is still passed, for compatibility reasons, but it no documented anymore

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Oct 18, 2019 •
edited
Loading

Codecov Report

Merging #3084 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/build/custom/custom.go 62.5% <100%> (ø) ⬆️
pkg/skaffold/server/server.go 58.57% <0%> (ø) ⬆️

tejal29
tejal29 previously approved these changes Oct 18, 2019
View reviewed changes
@tejal29 tejal29 changed the title [Custom] Use $IMAGE instead of $IMAGES [Custom] [Deprecation] Use $IMAGE instead of $IMAGES Oct 18, 2019
@tejal29 tejal29 dismissed their stale review October 18, 2019 22:57

Please mention this in current deprecation notices.

@tejal29
Copy link
Member

tejal29 commented Oct 18, 2019

Can you please add these to current Deprecation notices to the Deprecation policy as well ?
https://skaffold-latest.firebaseapp.com/docs/references/deprecation/#current-deprecation-notices

We shd make sure this is captured in Release notes. Added Deprecation to the title.

@dgageot
Copy link
Contributor Author

dgageot commented Oct 21, 2019

Thanks @tejal29! I added a section in the Deprecation notices

nkubala
nkubala approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits but LGTM

docs/content/en/docs/references/deprecation/_index.md Outdated Show resolved Hide resolved
pkg/skaffold/constants/constants.go Outdated Show resolved Hide resolved
@dgageot dgageot merged commit 069bb55 into GoogleContainerTools:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Custom builder] $IMAGES is always a single image
4 participants
@dgageot @tejal29 @nkubala @googlebot