Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add logging docs #3170

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Nov 4, 2019

Initial skeleton for logging docs.

@tejal29 tejal29 added priority/p0 Highest priority. We are actively looking at delivering it. docs-modifications runs the docs preview service on the given PR labels Nov 4, 2019
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

1 similar comment
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 4, 2019
@container-tools-bot
Copy link

Please visit http://34.94.43.151:1313 to view changes to the docs.

@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

to your local machine when running in either `dev`, `debug` or `run` mode.

{{< alert title="Note" >}}
**Log Tailing is enabled by default in [`dev`](<relref docs="/docs/workflows/dev" >}}) and [`debug`](<relref docs="/docs/workflows/debug" >}}) modes**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Log Tailing is enabled by default in [`dev`](<relref docs="/docs/workflows/dev" >}}) and [`debug`](<relref docs="/docs/workflows/debug" >}}) modes**
Log Tailing is enabled by default in [`dev`](<relref docs="/docs/workflows/dev" >}}) and [`debug`](<relref docs="/docs/workflows/debug" >}}) modes

{{< alert title="Note" >}}
**Log Tailing is enabled by default in [`dev`](<relref docs="/docs/workflows/dev" >}}) and [`debug`](<relref docs="/docs/workflows/debug" >}}) modes**

**Log Tailing is disabled by default in `run` mode; it can be enabled with the `--tail` flag.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Log Tailing is disabled by default in `run` mode; it can be enabled with the `--tail` flag.**
Log Tailing is disabled by default in `run` mode; it can be enabled with the `--tail` flag.

@balopat balopat merged commit 24fdcca into GoogleContainerTools:master Nov 5, 2019
@tejal29 tejal29 deleted the add_logging branch April 15, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants