Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] move builders in to individual pages #3193

Merged
merged 8 commits into from
Nov 7, 2019

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Nov 6, 2019

Relates to #2904

The builder page was getting super long. With the addition of maturity snippet on the RHS, the index needed scrolling
Now they are broken in 3 parts.

  1. Local
  2. Remote
  3. Custom Build ( i created a new page for this since Custom Build had too many sub headings and if combined in Local, the index on the RHS again needed scrolling)

Other changes

  1. Updated the links on the main build/_index.md to point to the sub pages.
    Each subpage has a link to the tool which is linked along with some descriptions.

@tejal29 tejal29 added the priority/p0 Highest priority. We are actively looking at delivering it. label Nov 6, 2019
@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Nov 6, 2019
@container-tools-bot
Copy link

Please visit http://35.236.5.148:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 6, 2019
@tejal29 tejal29 changed the title move builders in to individual places [docs] move builders in to individual pages Nov 6, 2019
balopat
balopat previously requested changes Nov 6, 2019
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be awesome!

However, the breakdown should be local, on-cluster and Google Cloud Build, not local / remote / custom.

We support custom artifacts locally as well.
Thus:

  • local => dockerfile, jib, bazel, custom
  • cluster => dockerfile, custom
  • gcb => dockerfile, jib

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #3193 into master will not change coverage.
The diff coverage is n/a.

@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Nov 6, 2019
@container-tools-bot
Copy link

Please visit http://34.94.185.45:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 6, 2019
@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Nov 7, 2019
@container-tools-bot
Copy link

Please visit http://35.236.103.231:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 7, 2019
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Nov 7, 2019
@container-tools-bot
Copy link

Please visit http://35.236.13.246:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 7, 2019
@balopat balopat merged commit 8647a7c into GoogleContainerTools:master Nov 7, 2019
@tejal29 tejal29 deleted the builder-reorg branch April 15, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes priority/p0 Highest priority. We are actively looking at delivering it. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants