Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add docs for buildpacks #3198

Merged
merged 2 commits into from
Nov 7, 2019
Merged

[docs] add docs for buildpacks #3198

merged 2 commits into from
Nov 7, 2019

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Nov 7, 2019

Fixes #2904

Initial docs for buildpacks

  • Removed unused file.

@tejal29 tejal29 added priority/p0 Highest priority. We are actively looking at delivering it. docs-modifications runs the docs preview service on the given PR labels Nov 7, 2019
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

1 similar comment
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 7, 2019
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot
Copy link

Please visit http://35.236.70.48:1313 to view changes to the docs.

@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

to a container in a docker daemon. These get unmounted once the build process is finished.

Once all the necessary data is present, Skaffold will run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't need to talk about the lifecycle at all. It's the buildpacks specs, not really something interesting for end users. Or is it?

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #3198 into master will not change coverage.
The diff coverage is n/a.


Once all the necessary data is present, Skaffold wil build inside a container in a docker daemon
with image specified in `builderImage` in the `buildpack` config.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specified in builder


Skaffold buildpacks support, builds the image inside local docker daemon.
It mounts the source dependencies and local artifact cache if caching is enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It always mounts the cache (for now)

Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this PR and push a follow up PR to fix the last details.

@dgageot dgageot merged commit e8817b9 into master Nov 7, 2019
@dgageot dgageot deleted the add_buildpacks_docs branch November 18, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes priority/p0 Highest priority. We are actively looking at delivering it. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to buildpacks docs
4 participants