Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error instead of opening interactive prompt with --force init #3252

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Error instead of opening interactive prompt with --force init #3252

merged 2 commits into from
Nov 18, 2019

Conversation

TadCordle
Copy link
Contributor

@TadCordle TadCordle commented Nov 14, 2019

Fixes #3221.

skaffold init --force now shows an error if all builder/image pairs can't be automatically resolved.

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #3252 into master will increase coverage by 0.26%.
The diff coverage is 75%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/init.go 58.44% <75%> (+0.27%) ⬆️
pkg/skaffold/build/gcb/spec.go 93.75% <0%> (-6.25%) ⬇️
cmd/skaffold/app/cmd/run.go 47.05% <0%> (-5.58%) ⬇️
pkg/skaffold/build/custom/custom.go 58.13% <0%> (-4.37%) ⬇️
pkg/skaffold/docker/image.go 76.36% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/flags.go 100% <0%> (ø) ⬆️
pkg/skaffold/docker/containers.go 67.44% <0%> (ø) ⬆️
pkg/skaffold/build/cluster/sources/gcs.go 0% <0%> (ø) ⬆️
pkg/skaffold/gcp/client.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/gcb/buildpacks.go 100% <0%> (ø)
... and 2 more

Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

pkg/skaffold/initializer/init_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold init in force mode still opens interactive mode when choice is ambiguous
4 participants